From 706e20821a61d02d156f8e509297175c989f8763 Mon Sep 17 00:00:00 2001 From: hashlag Date: Sun, 18 Oct 2026 01:49:14 +0300 Subject: [PATCH] PadderPkcs7: delete default ctor. --- Chaos/Padding/PadderPkcs7.hpp | 2 ++ ChaosTests/Padding/PadderPkcs7Tests.cpp | 14 ++++++-------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Chaos/Padding/PadderPkcs7.hpp b/Chaos/Padding/PadderPkcs7.hpp index 61c4a60..b5141dc 100644 --- a/Chaos/Padding/PadderPkcs7.hpp +++ b/Chaos/Padding/PadderPkcs7.hpp @@ -16,6 +16,8 @@ namespace Chaos::Padding class PadderPkcs7 { public: + PadderPkcs7() = delete; + template static void Pad(OutputIt begin, OutputIt end) { diff --git a/ChaosTests/Padding/PadderPkcs7Tests.cpp b/ChaosTests/Padding/PadderPkcs7Tests.cpp index 57240ac..57e288a 100644 --- a/ChaosTests/Padding/PadderPkcs7Tests.cpp +++ b/ChaosTests/Padding/PadderPkcs7Tests.cpp @@ -138,9 +138,9 @@ TEST(PadPkcs7Tests, PadOutIteratorUsageTest) } template -void PadGeneric(const PadderImpl & padder, OutputIt begin, OutputIt end) +void PadGeneric(OutputIt begin, OutputIt end) { - padder.Pad(begin, end); + PadderImpl::Pad(begin, end); } TEST(PadPkcs7Tests, PadThroughBaseTest) @@ -152,8 +152,7 @@ TEST(PadPkcs7Tests, PadThroughBaseTest) 0x05, 0x05, 0x05, 0x05, 0x05 }; - const PadderPkcs7 padder; - PadGeneric(padder, fact.begin(), fact.end()); + PadGeneric(fact.begin(), fact.end()); ASSERT_EQ(expected, fact); } @@ -348,9 +347,9 @@ TEST(PadPkcs7Tests, UnpadErrorTest) } template -auto ComputeUnpadGeneric(const PadderImpl & padder, OutputIt begin, OutputIt end) +auto ComputeUnpadGeneric(OutputIt begin, OutputIt end) { - return padder.ComputeUnpad(begin, end); + return PadderImpl::ComputeUnpad(begin, end); } TEST(PadPkcs7Tests, ComputeUnpadThroughBaseTest) @@ -358,8 +357,7 @@ TEST(PadPkcs7Tests, ComputeUnpadThroughBaseTest) { std::array data = { 0x05, 0x05, 0x05, 0x05, 0x05 }; - const PadderPkcs7 padder; - auto result = ComputeUnpadGeneric(padder, data.begin(), data.end()); + auto result = ComputeUnpadGeneric(data.begin(), data.end()); ASSERT_TRUE(result.IsOkay_); ASSERT_EQ(5, result.PadSize_);