PadderPkcs7: delete default ctor.

This commit is contained in:
hashlag committed 2026-10-18 02:40:52 +03:00
1 parent e7f346cda2
commit 706e20821a
2 files changed
+8 -8

No files matched your search

+2
View File
@@ -16,6 +16,8 @@ namespace Chaos::Padding
class PadderPkcs7 class PadderPkcs7
{ {
public: public:
PadderPkcs7() = delete;
template<typename OutputIt> template<typename OutputIt>
static void Pad(OutputIt begin, OutputIt end) static void Pad(OutputIt begin, OutputIt end)
{ {
+6 -8
View File
@@ -138,9 +138,9 @@ TEST(PadPkcs7Tests, PadOutIteratorUsageTest)
} }
template<Padder PadderImpl, typename OutputIt> template<Padder PadderImpl, typename OutputIt>
void PadGeneric(const PadderImpl & padder, OutputIt begin, OutputIt end) void PadGeneric(OutputIt begin, OutputIt end)
{ {
padder.Pad(begin, end); PadderImpl::Pad(begin, end);
} }
TEST(PadPkcs7Tests, PadThroughBaseTest) TEST(PadPkcs7Tests, PadThroughBaseTest)
@@ -152,8 +152,7 @@ TEST(PadPkcs7Tests, PadThroughBaseTest)
0x05, 0x05, 0x05, 0x05, 0x05 0x05, 0x05, 0x05, 0x05, 0x05
}; };
const PadderPkcs7 padder; PadGeneric<PadderPkcs7>(fact.begin(), fact.end());
PadGeneric(padder, fact.begin(), fact.end());
ASSERT_EQ(expected, fact); ASSERT_EQ(expected, fact);
} }
@@ -348,9 +347,9 @@ TEST(PadPkcs7Tests, UnpadErrorTest)
} }
template<Padder PadderImpl, typename OutputIt> template<Padder PadderImpl, typename OutputIt>
auto ComputeUnpadGeneric(const PadderImpl & padder, OutputIt begin, OutputIt end) auto ComputeUnpadGeneric(OutputIt begin, OutputIt end)
{ {
return padder.ComputeUnpad(begin, end); return PadderImpl::ComputeUnpad(begin, end);
} }
TEST(PadPkcs7Tests, ComputeUnpadThroughBaseTest) TEST(PadPkcs7Tests, ComputeUnpadThroughBaseTest)
@@ -358,8 +357,7 @@ TEST(PadPkcs7Tests, ComputeUnpadThroughBaseTest)
{ {
std::array<uint8_t, 5> data = { 0x05, 0x05, 0x05, 0x05, 0x05 }; std::array<uint8_t, 5> data = { 0x05, 0x05, 0x05, 0x05, 0x05 };
const PadderPkcs7 padder; auto result = ComputeUnpadGeneric<PadderPkcs7>(data.begin(), data.end());
auto result = ComputeUnpadGeneric(padder, data.begin(), data.end());
ASSERT_TRUE(result.IsOkay_); ASSERT_TRUE(result.IsOkay_);
ASSERT_EQ(5, result.PadSize_); ASSERT_EQ(5, result.PadSize_);